Make t/op/magic.t pass on AlmaLinux 8’s kernel. #19691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwp0
reviewed
May 5, 2022
Contributor
rwp0
left a comment
rwp0
left a comment
There was a problem hiding this comment.
would be good to explicitly mention kernels/distros that do so in the comment as a short example
Contributor
Author
I don’t disagree, but I don’t know the full spate of systems that have been tested here. I’ll add a couple notes, though. |
toddr
approved these changes
May 11, 2022
Leont
approved these changes
May 11, 2022
Contributor
|
This has four approves now, and is a 5.36 release blocker. Can you merge it now please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #19690